https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35797 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #29 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi guys, failing QA: 1) Line 61 of patron_images.t is testing 'Patron not found' for the checkouts endpoint, not the new /default_image endpoint added here. 2) Unused import in V1::Patrons::Image: use MIME::Base64 qw( encode_base64 ); 3) The API controller should check for C4::Context->preference('patronimages') and return 403 if disabled. A library that deliberately disables patron images (e.g. for privacy reasons) would still expose them via the API. A test for this should also be included. 4) The tests are using a superlibrarian user and not testing the specific permissions the endpoint requires (list_borrowers/edit_borrowers) -- You are receiving this mail because: You are watching all bug changes.