https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47899&action=edit Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory C4::Koha::IsAuthorisedValueCategory contains only 2 useful calls, from C4::Reports::Guided and reports/guided_reports.pl It can be replaced with Koha::AuthorisedValues->search({ category => $authorised_value})->count Test plan: 1/ Create a sql report using an authorised value category, something like: SELECT COUNT(*) FROM items where lost=<<lost|LOST>> 2/ Execute the report and confirm that everything works fine. 3/ Create a sql report using a nonexistent authorised value categor, something like: SELECT COUNT(*) FROM items where lost=<<lost|NONEXIST>> 4/ When saving the report, you should get a warning message "lost: The authorized value category (NONEXIST) you selected does not exist." 5/ Save anyway and execute the report, you should get the same warning message. QA: git grep IsAuthorisedValueCategory should not return any results prove t/db_dependent/ReportsGuided.t should return green -- You are receiving this mail because: You are watching all bug changes.