https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #81 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Jonathan Druart from comment #80)
Lari, I have rebased the patches.
Wondering about find_with_message_name
Koha::Patron::Message::Preferences->find_with_message_name({ borrowernumber => 123, message_name => 'Hold_Filled', });
Should not we prefer something like:
$patron->messaging_preferences->filter_by_message_name('Hold_Filled'); or even: $patron->messaging_preferences->search({ message_name => 'Hold_Filled' });
ie why is it a class method?
Same for the setter, there is only 1 set_default_messaging_preferences, why cannot we add set messaging preferences directly from $patron?
I don't think there is a reason why we shouldn't have getters & setters in Koha::Patron as well. The purpose of that method was just to convert human readable message name into an id number. -- You are receiving this mail because: You are watching all bug changes.