http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
@@ +278,4 @@
- - "Restrict patrons with the following target audience values from checking out inappropriate materials:" - pref: AgeRestrictionMarker + - "E.g. Enter target audience keyword(s) split by | (pipe) FSK|PEGI|Age| (No white space near |). Be sure to map agerestriction in Koha to MARC mapping (e.g. 521$a). A MARC field value of FSK 12 or PEGI 12 would mean: 'Borrower must be 12 years old'. Leave empty to not apply an age restriction."
I was noticing 856u in another patch on this bug report. Are we doing 856u or 856$u? We have 521$a here. Should it be 521a?
I think 521$u makes sense, if we have other cases without $ we could fix them separately. I think some options require you to enter without $, so have to be careful fixing.
@@ -365,5 @@
choices: - confirm: "require confirmation" - alert: "display a message" - nothing : "do nothing" - - .
I like this '.' removal and placing at the end of the strings.
The extra . at the end creates a separate string in the translation files and is a little advantage for translations. Because it's not always easy to built a grammatically correct sentence that has the options at the end, this extra string for the . allows to split the sentence up and have some words after the option list - not sure if I used it here, but I did in some other cases.
@@ +523,5 @@
- pref: emailLibrarianWhenHoldIsPlaced choices: + yes: Do + no: "Don't" + - "send an email to the Koha administrator email address whenever a hold request is placed."
"Send" "Don't send"? I don't see why this change is necessary.
I think the change makes it a bit easier to read. -- You are receiving this mail because: You are watching all bug changes.