https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42295 --- Comment #39 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 202758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202758 Bug 42295: Tidy all script tags - staff includes Review of attachment 202758: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=42295&attachment=202758) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc @@ +42,5 @@
+ + const interface = "[% interface | html %]"; + const themelang = "[% themelang | html %]"; + const lang = "[% lang | html %]"; + const logged_in_user_borrowernumber = "[% logged_in_user.borrowernumber | html %]";
So this will replace using [% logged_in_user.borrowernumber | html %] without quotes. This variable that has quotes for the data initializing it. Before, from what I understand, it was a Koha::Patron object so borrowernumber would be an int. Then it means here we change to having the borrowernumber as a string instead of an int. Is this a planned change and does the consumers of logged_in_user_borrowernumber don't care about having an int vs that same int converted to a string? Or maybe the html filter was already converting the int to a string? And the quotes here are just redundant and change nothing so it's not a problem. -- You are receiving this mail because: You are watching all bug changes.