https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|unspecified |master --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. Minor comment (no blocker): The script contains a $total variable that seems to be unused (not passed to template). The template now contains: [% IF ( total || funds_exist ) %] <span>Cannot delete budget '[% budget_period_description %]'</span> The total check appears to be unneeded. Similary: [% IF ( delete_confirm ) %] [% IF ( total ) %] <div class="dialog message"> <h3>Cannot delete budget</h3> <p><strong>This record is used [% total %] times</strong> . Deletion is not possible.</p> [% ELSIF ( funds_exist ) %] <div class="dialog message"> <h3>Cannot delete budget</h3> <p>This budget has funds attached. You must delete all attached funds before you can delete this budget.</p> The total branch here probably was meant for existing funds, but seems unused. Passed QA -- You are receiving this mail because: You are watching all bug changes.