http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Failed QA --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Martin Persson from comment #5)
Setting to 'Needs Signoff' to get feedback.
Hi Martin, patches applies cleanly, no koha-qa errors It's ok to add new services, but please take into account Katrin and David comments. This will not pass in it's current form. Please add some kind of test plan, a tester need to know how to test and what to expect. Perhaps a passing test is enough, but we must know. Lastly, 'prove -v t/db_dependent/ILSDI_Services.t' now fails on last test not ok 18 - Test missing item info -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.