https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 --- Comment #71 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 209622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209622&action=edit Bug 42383: (QA follow-up) Use APIClient for libraries and translate store strings The check-in Pinia store fetched the libraries list with a raw fetch('/api/v1/libraries?_per_page=-1') while APIClient, which has a library client, is already imported and used for authorised values. It also set some user visible error messages as plain, untranslatable strings. This patch (QA comment point 17) loads the libraries through APIClient.library.libraries.getAll() and wraps the remaining English strings of the store with $__(). Test plan: 1. Apply this patch and rebuild: $ ktd --shell k$ yarn js:build k$ restart_all 2. Check an item whose home library is not the logged in library in on the check-in page, with AutomaticItemReturn enabled => SUCCESS: The 'Transfer to' column and the transfer modal show the home library name (not its code) 3. Check the store strings are picked up for translation: $ ktd --shell k$ cd misc/translator k$ perl translate update fr-FR k$ grep -A1 'Network error. Please try again.' po/fr-FR-messages-js.po => SUCCESS: The string is listed 4. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.