https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27834 --- Comment #29 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #28)
(In reply to Martin Renvoize (ashimema) from comment #27)
You're right that this creates 9 possible combinations. However, this was actually at Nick's suggestion.
@Nick: Could you clarify in this context why we need this flexibility? To me it feels like sacrificing consistency on circ rules.
The original patches had: CheckoutLimitScope - options All / BranchSpecific if BranchSpecific was chosen, we then followed CircControl CircControl - options PickupLibrary, PatronLibrary, ItemHomeLibrary What I didn't like was the combo BranchSpecific+PickupLibrary - since 'PickupLibrary' didn't really read right My suggestion of a new pref does make 9 combinations, but I think it makes sense as these are two things being controlled: 1 - CircControl - decides which circ rule are we using - these patches don't change this, we will still use the same rule as before 2 - CheckoutLimitScope - decides how we count the patron's checkouts against the rule - this is what libraries don't like, that the choice in #1 decides #2 - this is why I think it should be independent -- You are receiving this mail because: You are watching all bug changes.