http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #56 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Robin Sheat from comment #55)
(In reply to Jonathan Druart from comment #52)
Created attachment 33746 [details] [review] [review] Bug 11998: Add Koha::Config::SystemPreference
This (dirty) patch extract the syspref set and delete routine into a module. It fixes the circular dependency and the logging problem.
That's probably the better solution. Though, the caching should happen inside the module too. Eventually this means we could move away from using C4::Context->preference, but for now we maintain a compatibility shim.
The idea was to have a quick and safe patch for 3.18. The SystemPreference module will have to be rewritten in a OO way. -- You are receiving this mail because: You are watching all bug changes.