https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37201 --- Comment #11 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- (In reply to David Nind from comment #7)
I've attempted to test, but I'm not sure exactly what is intended here.
I've attached some screenshots (next comment) without the patch and with the patch (with the new system preference set to allow and don't allow).
Without this patch: 1. I can still checkout past or expired bookings. If attempted to change a booking to a checkout, staff have the option to "Yes, check out (Y)", or "No, don't check out (N)".
With this patch: 1. Set to "Allow": no change 2. Set to "Don't allow": extra bulleted sentence: "Booking ended on 08/03/2026 would you force the checkout?"
Testing notes (using KTD):
1. Step 3: - koha-mysql kohadev - update bookings set start_date = "2026-08-01 00:00:00"; - update bookings set end_date = "2026-08-03 00:00:00";
2. When I set AllowExpiredBookingTransformation to "Don't allow", the only thing that is different is that for the "Please confirm checkout" (in yellow) there is an extra sentence at the start which says: "- Booking ended on 08/03/2026 would you force the checkout?"
3. Section for new system preference: - The ew system preference was put in Circulation > Lost item policy - I think this should be in Circulation > Booking module
4. Description for the new system preference: - Current: [Allow/Don't allow] patrons to transform a past booking into checkout. - Suggested: [Allow/Don't allow] staff to transform an expired booking into a checkout. - Rationale: "patrons" - can only be done in the staff interface, so "staff" or "staff patrons"
Hello David, Thanks for the testing. The previous patch was confusing and barely changed anything. New version attached. Note: the “Yes/No” prompt you saw without the patch is the generic “due date in the past” confirmation (the bookings list submits the booking’s past end_date as the checkout due date), not a booking check. I've reworked this and added a `BOOKED_EXPIRED` case, which is hopefully clearer. -- You are receiving this mail because: You are watching all bug changes.