http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should go with the first patch - fixing GetReserveStatus will take a lot more work and testing all the places it is in now too. The only reserve status interesting for renewals is if something can actually fill a hold. If it's checked out, it will not be waiting on the pickup shelf (W). Also it being filled (F) would not be blocking renewal - and GetReserveStatus is not querying the right table for that status anyway (old_reserves). I think fixing this bug, we need to revert to using CheckReserves - it's the same routine that is used on checkin, so it makes the most sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.