https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20486 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 73999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73999 Bug 20486: Add --marc_conditions option to export_records.pl Review of attachment 73999: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20486&attachment=73999) ----------------------------------------------------------------- Same question as on bug 20465: this adds functionality to the CLI script that is not available in the export tool in the GUI. Do we want them to diverge like that? Requesting feedback. Also: QA scripts shows a POD issue: FAIL misc/export_records.pl OK critic OK forbidden patterns OK git manipulation FAIL pod Apparent command =back not preceded by blank line *** ERROR: =over on line 263 without closing =back (at head1) in file misc/export_records.pl ::: Koha/Exporter/Record.pm @@ +77,5 @@
+ return undef unless all { $op->($_, $match_value) } @target_values; + } + } + } + return undef if $no_target && $operator ne '!='; # TODO: ??
Gives me an uneasy feeling. What was the thought here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.