https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41977 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 194384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194384&action=edit Bug 41977: Hold fee not charged for title-level holds when all items are on order Koha's convention is that notforloan <= 0 means "holdable" and notforloan > 0 means "not holdable". This is documented in both IsAvailableForItemLevelRequest() and CheckReserves(): "item with negative or zero notforloan value is holdable" _calculate_title_hold_fee() was only searching for items with notforloan = 0 or IS NULL, silently excluding items with negative notforloan values (e.g. -1 = "Ordered"). When all items on a title had a negative notforloan status, no items were found, @fees was empty, and the method returned 0 — causing no fee to be charged. Fix the filter to use <= 0 so it matches the same holdability rule used consistently elsewhere in the codebase. Sponsored-by: OpenFifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.