https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18899 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 64858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64858 Bug 18899 - Tests should skip instead of failing when dependency modules are not installed Review of attachment 64858: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18899&attachment=64858) ----------------------------------------------------------------- You write: test 342 requires Catmandu::Importer::MARC tests 521 and 533 require WebService::ILS::OverDrive::Patron test 1 requires Catmandu::Store::ElasticSearch But then your code has no explicit mention of them. I think this needs some logic clean up, sorry. Even comments explaining the relationship between the requires done and why they are failing (the ones above) would be an improvement. ::: t/db_dependent/00-strict.t @@ +31,5 @@
+if ( $@ ) { + push @skips, 'opac/svc/overdrive'; +} + +eval { require Koha::ExternalContent::OverDrive; };
This is identical to line 29. Why didn't you place line 38 as line 33? That is do both pushes in the single $@. -- You are receiving this mail because: You are watching all bug changes.