https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #28 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- (In reply to Jonathan Druart from comment #25)
(In reply to Jonathan Druart from comment #24)
Comment on attachment 54942 [details] [review] [review] Bug 16330: REST API: add routes to add, update and delete patrons
Review of attachment 54942 [details] [review] [review]: -----------------------------------------------------------------
::: Koha/REST/V1/Patron.pm @@ +172,5 @@
+ } elsif ($res eq '-1') { + return $c->$cb({}, 404); + } else { + return $c->$cb({}, 400); + }
It may be better to surround the ->delete with an eval, returns 200 if == 1 or log the error and return 500, don't you think?
Or 400 instead.
yes. Thanks for thorough feedback, btw! -- You are receiving this mail because: You are watching all bug changes.