https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 --- Comment #104 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 209764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209764&action=edit Bug 42383: (QA follow-up) Show 'Available for loan' for a not for loan value of 0 When UpdateNotForLoanStatusOnCheckin sets an item's not for loan status to 0, the check-in page displayed the raw '0' as the new value. The avDescription helper only treated undef and the empty string as 'Available for loan', while the legacy returns.tt treated any false value (including 0) that way. This patch adds notForLoanDescription, which shows 'Available for loan' for any value that is not a non-zero number, and locationDescription for the UpdateItemLocationOnCheckin message. The latter also fixes an empty shelving location being displayed as 'Available for loan': it now shows 'Blank', as the legacy page did. Test plan: 1. Set UpdateNotForLoanStatusOnCheckin to: BK: 1: 0 2. Check out a BK item, then set its not for loan status to 1 3. Check the item in on the check-in page => FAIL: The message reads 'Not for loan status updated. Old value: ... New value: 0.' 4. Apply this patch and rebuild the JS: $ ktd --shell k$ yarn build 5. Repeat steps 2 and 3 => SUCCESS: The new value reads 'Available for loan' 6. Set UpdateItemLocationOnCheckin to: _BLANK_: CART and check in an item with no shelving location => SUCCESS: The old value reads 'Blank' 7. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.