https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Emily Lamancusa from comment #23)
Generally the code looks good, and the dbrev is idempotent.
One big concern, though - should all of the foreign keys be ON DELETE CASCADE? With the exception of additional_fields, the field is nullable, and when removing conflicts before applying the foreign key, the dbrev sets them to null. Shouldn't the foreign key constraint do the same if the authorized value is deleted?
Good catch. (In reply to Katrin Fischer from comment #24)
I agree with Emily, I think we should set NULL and not delete on cascade here.
+ 'additional_fields' => 'authorised_value_category', + 'auth_subfield_structure' => 'authorised_value', + 'auth_tag_structure' => 'authorised_value', + 'borrower_attribute_types' => 'authorised_value_category', + 'club_template_enrollment_fields' => 'authorised_value_category', + 'club_template_fields' => 'authorised_value_category', + 'marc_tag_structure' => 'authorised_value',
Especially the removals from the MARC bibliographic/authority data can lead to data loss easily if we remove the tag and subfield definitions.
Agreed. -- You are receiving this mail because: You are watching all bug changes.