https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #19 from Andreas Roussos <a.roussos@dataly.gr> --- Thank you all for your valuable feedback! Please see my answers below: (In reply to Katrin Fischer from comment #11)
I think if we update the plugin, we will also want to change the version coded in the file name, so we force browsers to load the updated file: Done. I will attach an updated patch that renames the plugin.
Also, your change is only for the OPAC, we probably need to update in the staff interface separately. Actually, my first patch took care of both. See here: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128053&action=diff
(In reply to Amaury GAU from comment #15)
I can't reproduce the Test Plan. Everything seems correct before and after applying the patch, in both the Staff interface and the OPAC. Indeed, when I try the test plan on the current master (commit 9863c18cc8) I get what Katrin observed in Comment 11. However, if I set up a UNIMARC test instance on master I still get the disappearing "Highlight" button but now only in the OPAC! Also, in both the Staff interface and the OPAC the following message is displayed in the JavaScript Console: Uncaught DOMException: Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length.
This might have been corrected throughout the updates. Probably needs some checkup. I will upload two more screenshots to show the highlighting behaviour in a UNIMARC instance, and will adjust the test plan.
(In reply to Fridolin Somers from comment #18)
We need to rename jquery.highlight-3.js => jquery.highlight-5.js no ? Yes, we do. My updated patch will take care of this.
-- You are receiving this mail because: You are watching all bug changes.