http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #4)
Note: I did not test the feature! Too bad, but thanks anyway..
1/ It would be good to use perltidy on this new file. Fixed that
2/ Don't you think it is better to have a pod instead of the "print <<_USAGE_" stuff (and to use Pod2Usage)? Not sure, but moved it to pod.
3/ SQL strings should be between simple quotes. Also not sure about that. I replaced most of them. But had one case: " AND COALESCE(explanation,'')='' AND COALESCE(options,'')=''" where I could not replace them..
Back to Signed Off -- You are receiving this mail because: You are watching all bug changes.