https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30856 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3)
Created attachment 171064 [details] [review] Bug 30856: Move CanReserveBeCanceledFromOpac to Koha::Policy
Why are we adding a whole new module for the hold policy? Instead of fetching the patron just to compare borrowernumber, why not: my $hold = Koha::Holds->find({ reserve_id => $reserve_id, borrowernumber => $borrowernumber }); If the borrowernumebr doesn't match, we don't find a hold, can't cancel? I agree the caller can be responsible for checking params. The ILSDI call at least also seems wrong, should check: $hold->cancellation_requestable_from_opac but that's for another bug -- You are receiving this mail because: You are watching all bug changes.