https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40655 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Brendan Lawlor from comment #3)
This fixes the two issues described by Lisette, but there is still a bad bug with saving the matrix.
The number saves as expected
Disabled is saved, but the number is not
This time when the page loads that cell can't be edited anymore and you get an error like: There were problems with your submission Invalid value for Centerville -> Fairfield
To recreate: 1. Apply the patch 2. Enable UseTransportCostMatrix and go to Administration > Transport cost matrix 3. Click in a box, uncheck disable, add a number and click save 4. In the same box click again, check disable and click save 5. In the same box click again, uncheck disabled and click save 6. Refresh the page, same error and you still can't edit that cell. The user can break the ability to edit any cell like this.
For number 4, is the value supposed to be cleared when you disable it?
The function check_transport_cost(e) only runs on blur. That doesn't prevent the user from clicking the save button when there's an empty value there and that breaks the way the form is rendered.
This may be a separate bug , but even if the alert pops up, the user can just ignore it and put any string value and click save, it's not doing proper form validation.
Hey Brendan, I notice this behavior is also present as far back as 24.11.x. I also wondered if the value should be lost when we disable it. Since the bugfix in the patch is bad, libraries cannot edit their TCM, can we file this as a seperate bug and get this one in ASAP? -- You are receiving this mail because: You are watching all bug changes.