https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30724 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Nick Clemens (kidclamp) from comment #30)
(In reply to Jonathan Druart from comment #25)
Created attachment 187964 [details] [review] [review] Bug 30724: Fix selenium tests - info => success class
I don't think this is correct. We only want success after we enabled 2FA
I am not sure of the problem here - you check for alert-success - but only expect it not blank when 2FA enabled, unless I misread
We want the alert-success class only after the form is submitted. When you go to members/two_factor_auth.pl?borrowernumber=51 and the 2FA is enabled it should be alert-info.
(In reply to Jonathan Druart from comment #26)
This third patch fixes the selenium tests but they are not correct IMO.
We still need new tests to cover changes from this bug report.
More tests are always good, opened bug 41038
It's not "always good", it's mandatory when it's auth and we have already tests covering the area ;) -- You are receiving this mail because: You are watching all bug changes.