http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #13)
Yes of course, but in fact the only data I create is the borrower. So if the DB contains at least 1 borrower, this patch is useless. That's a little too strong of a requirement, IMO, as I, for one, and I suspect most developers, would like to be able to run the DB-dependent tests in our normal testing databases.
Currently nobody is able to launch them, and the goal is to launch tests with sample data. They don't insert patron, so I think we have to have some prerequisites.
I rather suspect what Jared is running into is that his test database already has a patron whose cardnumber is CARDNUMBER42.
Yes, it was maybe to "generic" :) (In reply to Galen Charlton from comment #14)
Pushed to master. Thanks, Jonathan!
I've also pushed two follow-ups, one to wrap the tests in a transaction and another to remove the hard-coded patron cardnumber, which doesn't need to be set to any specific value for the tests to work.
Thanks for the followups! But now tests fail if a borrower exists with a cardnumber == NULL (and I don't have any idea how it's happen, but I got 1 in my DB :)) -- You are receiving this mail because: You are watching all bug changes.