http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38119|0 |1 is obsolete| | --- Comment #24 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39171&action=edit [SIGNED-OFF] Bug 8688: Update License, Perlcritic -3 friendly This patch tweaks the license information to v3, as per the license found in the Coding Guidelines on the wiki: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence This also changes: use strict; use warnings; into: use Modern::Perl; As per the PERL2: Modern::Perl requirement in the Guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL2:_Modern::Perl And though the guidelines only require perlcritic -5, a single line tweak gets a bump to perlcritic -3. TEST PLAN --------- 1) perlcritic -5 circ/send_recall_notice.pl -- success, so technically no change was required. 2) perlcritic -3 circ/send_recall_notice.pl -- fails 3) apply patch 4) perlcritic -3 circ/send_recall_notice.pl -- success 5) run koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.