http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #88 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- (In reply to Paola Rossi from comment #86)
Kind Olli-Antti Kivilahti,
Thank you so much for testing this patch Ms. or Mrs. Rossi!
I've applied the patch against master 3.17.00.035.
I've upgraded the DB from a one that had been filled with some holds.
After having applied, by mysql command line, on the DB I saw the new field "lastpickupdate" of the table "reserves" as required; in all the holds this new field was set to NULL.
Sorry, my test plans were not complete. I added the following clause: 0. BEFORE UPDATING THE DATABASE! MAKE SURE THAT THE SYSPREF 'ReservesMaxPickUpDelay' is bigger than 0. Otherwise existing reserves won't get UPDATEd with the new lastpickupdate-values.
About this step: 4. In the 4 templates, you can see the 'Last pickup date' for an hold (circ/circulation.tt, circ/waitingreserves.tt, members/moremember.tt, opac-user.tt)
in circ/circulation.tt (CIRC, Check out, Holds) and members/moremember.tt (Patrons, patron X, Details, Holds) there was the title "Last pickup date" of the new column (the 2-nd from the left) of the table, but the datas in the cells below it were the titles. All the other datas on the right were shifted on the left by 1 column, and the last column "Delete?" of the table had nothing in the cells below it.
I created a new hold for a patron without holds, and the problem was the same on both the *.tt .
Are you sure you used the english language? I have encountered this issue mostly with not-up-to-date language templates. I retested this feature and was unable to replicate your report.
About opac-user.tt, I logged in to OPAC as a patron with n holds. Here ("your summary", tag "Holds (n)") I didn't see any new column.
Sorry, updated the TEST PLAN as follows: 5. In opac-user.pl the last pickup date is displayed in the status-column if available.
So I pass the patch to "Failed QA" status. Thanks for testing! Hope to hear from you soon :)
-- You are receiving this mail because: You are watching all bug changes.