https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28312 Bug ID: 28312 Summary: We should not assume hold pickup branch = ReservesControlBranch when checking it holds are allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: tomascohen@gmail.com Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To replicate: - Have branches A & B - In the Libraries setup, set A to be a pickup location, B to not be a pickup location - Set ReservesControl to Item's Home Library - Have a bib with two items, one owned by each branch - Confirm circ rules say all items on your bib are holdable by all patrons - On your bib, try to place a hold via the intranet - Confirm Koha allows a hold on the bib or on the Branch A item, but the Branch B item gives the message "libraryNotPickupLocation" As Koha checks whether each hold is allowed, it assumes a pickup branch of whatever's indicated by ReservesControl. So it assumes the Branch A item would be a hold for pickup at Branch A (allowed location) and the hold for the Branch B item would be for pickup at Branch B (un-allowed location). But that assumption is wrong. -- You are receiving this mail because: You are watching all bug changes.