http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5877 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #49 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-22 17:14:56 UTC --- (In reply to comment #47)
QA Comment (first patch): Looks good in general, just a few points need attention.
C4/Circulation.pm: Please adjust or send a follow up for AddOfflineOperation: The insert statement does not mention the field names. If the table structure is changed some day, this kind of statement will fail. good catch ! follow-up coming.
offline_circ/list.pl, offline_circ/process.pl, offline_circ/service.pl: Address of Free Software Foundation is not correct. good catch too. I also have fixed the FSF address ... in updatedatabase, as it was wrong here too !
I also have fixed some tabs (replaced by 4 spaces) and removed the ` in the table creation.
Please add use strict and use warnings. same thing : in the follow-up i'll attach now. they don't issue any warning.
switching to "signed off", then changes are QA changes that should have no effect on the feature itself -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.