http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|Signed Off |Patch doesn't apply Patch complexity|--- |Medium patch QA Contact| |paul.poulain@biblibre.com --- Comment #27 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * the patch does not apply anymore, there's a conflict on C4/Koha.pm. It seems to be easy to fix, but I let you do, to avoid a mistake * The DB update, you write "ALTER TABLE branches MODIFY branchprinter varchar(20) NULL, ADD FOREIGN KEY (branchprinter) REFERENCES printers (printqueue) ON UPDATE CASCADE" => why not also add ON DELETE SET NULL (on delete cascade would be a strong mistake, you don't want to delete branches just because you deleted a printer !!!) ? No other comments yet -- You are receiving this mail because: You are watching all bug changes.