https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34353 --- Comment #5 from Olivia Reynolds <olivia@memlen.com> --- Created attachment 198213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198213&action=edit Bug 34353: Remove 'SpineLabelShowPrintOnBibDetails' syspref With the ability to customise which columns are hidden by default as part of "Table settings", this syspref is redundant. As part of the atomicupdate, we incorporate the previous syspref value into columns_settings. As there are six possible states the migration could start from (the syspref can be 0 or 1, and the table setting can be 0, 1, or NULL) and two final states it must be idempotent from, the test plan is unfortunately quite cumbersome. Test plan: 1. Reset the database, to clear the table settings. 2. Apply patch and update the database. 3. Navigate to Administration > System preferences > Cataloging. 4. Verify that "SpineLabelShowPrintOnBibDetails" does not appear. 5. Navigate to a catalogue detail page. 6. Verify that the "Spine label" column is hidden. 7. Update the database again. 8. Navigate to a catalogue detail page. 9. Verify that the "Spine label" column is hidden. 10. Revert the patch. 11. Reset the database, to clear the table settings. 12. Navigate to Administration > System preferences > Cataloging. 13. Set "SpineLabelShowPrintOnBibDetails" to "Show" and save. 14. Apply patch and update the database. 15. Navigate to a catalogue detail page. 16. Verify that the "Spine label" column is visible. 17. Update the database again. 18. Navigate to a catalogue detail page. 19. Verify that the "Spine label" column is visible. 20. Revert the patch. 21. Reset the database, to clear the table settings. 22. Navigate to Administration > Table settings. 23. Under Catalog > holdings_table, check "Is hidden by default" for "spinelabel" and save. 24. Apply patch and update the database. 25. Navigate to a catalogue detail page. 26. Verify that the "Spine label" column is hidden. 27. Revert the patch. 28. Reset the database, to clear the table settings. 29. Navigate to Administration > System preferences > Cataloging. 30. Set "SpineLabelShowPrintOnBibDetails" to "Show" and save. 31. Navigate to Administration > Table settings. 32. Under Catalog > holdings_table, check "Is hidden by default" for "spinelabel" and save. 33. Apply patch and update the database. 34. Navigate to a catalogue detail page. 35. Verify that the "Spine label" column is hidden. 36. Revert the patch. 37. Reset the database, to clear the table settings. 38. Navigate to Administration > Table settings. 39. Under Catalog > holdings_table, uncheck "Is hidden by default" for "spinelabel" and save. 40. Apply patch and update the database. 41. Navigate to a catalogue detail page. 42. Verify that the "Spine label" column is hidden. 43. Revert the patch. 44. Reset the database, to clear the table settings. 45. Navigate to Administration > System preferences > Cataloging. 46. Set "SpineLabelShowPrintOnBibDetails" to "Show" and save. 47. Navigate to Administration > Table settings. 48. Under Catalog > holdings_table, uncheck "Is hidden by default" for "spinelabel" and save. 49. Apply patch and update the database. 50. Navigate to a catalogue detail page. 51. Verify that the "Spine label" column is visible. Thanks-to: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes.