https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40254 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183557|0 |1 is obsolete| | Attachment #183558|0 |1 is obsolete| | --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 183560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183560&action=edit Bug 40254: Fix error in overrides check allowing too much This patch fixes a subtle (yet naive) error making the controller not care about blocking conditions if they were more than one and the first one was overridden. To test: 1. Apply the regression tests 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail! Some tests expect a 409 (denied for a conflict) but return a 201! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.