https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@deichman.n | |o, | |boutrosboutrosboutros@gmail | |.com --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- As far as I can tell from the code and memory this is what was supposed to happen: - If NorwegianPatronDBEnable is enabled, a radio button named "sync" is added to the member add/edit form: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet... This makes it possible to turn syncing on and off for individual patrons, as required by the Norwegian patron database. - The value of "sync" from the form is then stored in the database as borrower_sync.sync: http://schema.koha-community.org/18_05/tables/borrower_sync.html here: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Members.pm;h=a8... So the value for "sync" is passed into ModMember from the member add/edit form, if NorwegianPatronDBEnable is enabled. As far as I can tell, the FIXME at http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/Patron.pm;h=9... that now looks like this: # FIXME THIS IS BROKEN # $borrowersync->update( { 'sync' => $data{'sync'} } ); should look like this: $borrowersync->update( { 'sync' => $self->sync } ); Does that make sense? It would be great to hear the opinions of Benjamin and/or Petter at OPL on this, since they are the ones running this code in production. I'm adding them to the CC list. -- You are receiving this mail because: You are watching all bug changes.