https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889 Bug ID: 20889 Summary: Items marked as not for loan can be checked out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 19943 To recreate: 1. Item type defined at item level (item-level_itypes=1) 2. Mark an item type not for loan (itemtypes.notforloan=1) 3. Checkout an item using this item type (items.itype="BK" for instance) => Checkout is not blocked! I suspect commit 3953fdb921d7f280ffbaca813956357aa67d42ca Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued to be the root of this issue. One occurrence of $item->{itemtype} has not been replaced. In this case it refers to the biblioitem->{itemtype} value whereas we want to use $item->{itype}. So this issue does not happen if items.itype==biblioitem.itemtype (just in case you are not reproducing the problem). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 [Bug 19943] Koha::Biblio - Remove GetBiblioItemData -- You are receiving this mail because: You are watching all bug changes.