https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 117464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117464&action=edit Bug 24359: (QA follow-up) Fix tests This patch fixes a rebase issue, and also makes sure the tests do not rely on any prior data. The query on tmp_holdsqueue is done against the actual reserve_id so no need to delete all the data from the tmp_holdsqueue and hold_fill_targets table. I also noticed the previous subtest wasn't run inside a transaction even if the code was designed to not depend on prior data as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/HoldsQueue.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.