http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #8)
(In reply to Jonathan Druart from comment #7)
(In reply to Bernardo Gonzalez Kriegel from comment #6)
(In reply to Jonathan Druart from comment #4)
This is a "feature". Why did you remove it?
I think the pourpose of this patch is to force the selection of a filter, so removing this first submit makes sense, the one left is under filters.
Yes but it causes a regression with bug 11272. Nicole could I get your opinion on this change please?
You are right. I tested re-adding it (first submit) and still works, generating the (scary) message Perhaps switch to in discussion?
I think the regression on 11272 is acceptable. This is because the premise of that bug is that uploading a barcode file and generating a list of items to view are completely independent operations. They are not: if you upload a file of barcodes, the code doesn't just mark them seen, it also tries to compare them against a range of items specified by the filter fields to identify missing ones. -- You are receiving this mail because: You are watching all bug changes.