https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25382 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #4)
Hi David,
while this works, there are a few catches:
1) I feel like the unconditional carp here is not necessary. We usually don't ouput erros like this in the logs.
I was just copying the style used elsewhere in those same scripts. Happy not to include it if you don't want it.
2) You pass parameters to the template - why not have a specific error message? At the moment we always have: There was an error sending the cart. For the user that could read like there is a server issue, not an issue with the entered information.
I was just copying the style used elsewhere in those same scripts. I didn't think this was a good opportunity to change the error handling for the whole script.
3) I think we should also add additional client side validation like we have on the email fields on the staff client or in the patron details form in OPAC. This way we can give even more specific feedback in a standard way.
That's a good idea. My patch is mostly to address security issues, but a better user experience is a great idea.
Failing for 1, but it would be great if you could consider 2 and 3 as well.
I'm not sure these points deserve the patch to be failed, but I'd be willing to remove the carp to get it moving again. If points 2 and 3 are necessary, I'll just leave this patch for now. -- You are receiving this mail because: You are watching all bug changes.