https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36093 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Completely missed this QA review! (In reply to Jonathan Druart from comment #5)
1. You are not supposed to tidy the whole pm to make the QA tests pass
Noted, will bear in mind for future patches
2. Why do you set date_uploaded in the tests, that's not needed.
This can be removed
3. + Koha::ERM::EUsage::MonthlyUsages->search->delete; You should not need to remove data before tests. You can count how many are there before the tests then do a sum.
I think probably when I wrote this test I had some data in the system already that was corrupting the test figures? I'll remove these lines and re-test -- You are receiving this mail because: You are watching all bug changes.