https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40773 Bug ID: 40773 Summary: Improve build of "vue/dist" files Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org I've been thinking how the "rm -rf koha-tmpl/intranet-tmpl/prog/js/vue/dist/*" step discussed in "Bug 37911 - Prototype vue islands within static pages" for a build from a git working directory isn't intuitive or easy to know about. I've also heard of stories where people building from git repos are still getting files included even though they've run "rm -rf koha-tmpl/intranet-tmpl/prog/js/vue/dist/*". This should be impossible, so there's probably something else going on there, but I think I have a solution which removes the necessity for this step anyway. (Note that for Debian package installs and regular tarball installs, the step isn't needed at all, because the tarballs are generating using "git archive" which doesn't include "vue/dist" files.) Anyway, the solution is to tell Makefile.PL specifically not to include "koha-tmpl/intranet-tmpl/prog/js/vue/dist/*" in the "$file_map" data structure. That way, it should be impossible for these files to wind up in the "blib" except where we copy them in via the "move_compiled_js" target from bug 39849 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.