https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42001 --- Comment #20 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201370&action=edit Bug 42001: Align duplicate order email notifications with acquisitions conventions - Rename preferences to the Edifact* namespace, placing them adjacent to related Edifact* prefs on the system preferences page: EdiDuplicateOrderEmailNotice -> EdifactOrderSendBlockDuplicatesEmailNotice EdiDuplicateOrderEmailAddresses -> EdifactOrderSendBlockDuplicatesEmailAddresses - Change EdifactOrderSendBlockDuplicatesEmailNotice from YesNo to Choice, matching the EmailPurchaseSuggestions pattern. Options: Do not send / AcquisitionsDefaultEmailAddress / specific email addresses / KohaAdminEmailAddress. - EdifactOrderSendBlockDuplicatesEmailAddresses is now only used when the choice is set to 'specific email addresses'. - Pass from_address (AcquisitionsDefaultEmailAddress with fallback) and reply_address (AcquisitionsDefaultReplyTo) to EnqueueLetter for both library and vendor notifications. - Add UPDATE in atomicupdate to migrate existing YesNo installs to Choice. - Fix test mock values for EmailNotice from old YesNo (1) to the correct Choice value ('EdifactOrderSendBlockDuplicatesEmailAddresses'). - Update C4/UsageStats.pm with new pref names. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.