https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ha yes I got it! Unfortunately your patch does not look the way to fix it, if you modify the return value of this subroutine you will certainly introduce several side-effects as it is tested at different place. I think you can patch it modifying the line with something like: @return = checkpw_internal( $dbh, $userid, $password, $no_set_userenv) unless $return[0]; or, if you want to be explicit: @return = checkpw_internal( $dbh, $userid, $password, $no_set_userenv) if $return[0] == 0; At this point @return always contains at least one element. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.