http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #95 from M. Tompsett <mtompset@hotmail.com> --- The difficulty of a multi-patch bug fix is changing just parts after a code review. Only the ones with [NEEDS SIGN OFF] are changed compared to earlier versions which Chris Cormack signed off. These changes include: - chopping an unused template parameter (comment #68 - point 1) - simplifying the lang/branchcode query building logic (comment #68 - point 3) - using Library or Libraries instead of Branch or Braches in the template (comment #68 - point 4) - white space fixes (comment #68 - point 6) - renaming a variable from hashref to parameters (comment #55) To recap the other comments by Jonathan Druart: comment #68 - point 2: parameter is still there, and left for historical and future expansion purposes. comment #68 - point 5: empty div's can be styled without breaking javascript. comment #68 - point 7: it probably should be 0, but left undef, so obvious change was only the addition of branch code. I figure 4+ parameters deserve a hashref as a parameter. -- You are receiving this mail because: You are watching all bug changes.