https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
I am not sure the patch is the correct way to fix it. If no value has not been filled in, we shouldn't default.
In my opinion we should better improve the way we calculate/retrieve the rules instead.
I think this fix is correct for current use of rules as a 'row' - we have all the current rules inthe table grouped, and don't expect to fall back on any individual column if a row is set for a patron/category type I do think there are other issues: bug 28774 made rentaldiscount not save if blank, but creates the same issue here of defaulting to a higher rule level unseen_renewals of '0' seems to translate to 'unlimited' - I don't think that's correct -- You are receiving this mail because: You are watching all bug changes.