https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24368 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #7)
Regarding the failing tests from bug 25421, I am not sure what you provided is equivalent. The POD of Koha::Libraries->pickup_locations said "- C. none of the above, simply all libraries with pickup_location => 1", but it's wrong, the code is:
my @pickup_locations; foreach my $library ($libraries->as_list) { if ($item && $item->can_be_transferred({ to => $library })) { push @pickup_locations, $library->unblessed; } elsif ($biblio && $biblio->can_be_transferred({ to => $library })) { push @pickup_locations, $library->unblessed; } }
With this change we are loosing the "can_be_transferred" conditions.
No we are not. That part is covered in $item->pickup_locations and $biblio->pickup_locations respectively, which is what is used in the template plugin. The only remaining use of Koha::Libraries->pickup_locations in the plugin was the 'just search pickup_locations => 1. -- You are receiving this mail because: You are watching all bug changes.