https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41410 --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 200349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200349&action=edit Bug 41410: Unit tests Covers the new LocalHoldsPriorityExclusivityPeriod behaviour and keeps existing tests working with the schema change: - t/db_dependent/Holds/LocalHoldsPriority.t: new subtest exercising all four cases -- pref disabled, pref active on a fresh hold, pref active past the window, and pref active with no hold_fill_targets row (queue hasn't run). - t/db_dependent/HoldsQueue.t: assert that after CreateQueue() with a local-group match, both tmp_holdsqueue and hold_fill_targets rows carry local_holdgroup_match = 1. - t/db_dependent/Reserves.t, t/db_dependent/Koha/Hold.t: qualify the two direct "INSERT INTO hold_fill_targets VALUES (...)" statements with explicit column names so they continue to work now that hold_fill_targets has one extra column. Test plan: prove t/db_dependent/Holds/LocalHoldsPriority.t \ t/db_dependent/HoldsQueue.t \ t/db_dependent/Reserves.t \ t/db_dependent/Koha/Hold.t All tests should pass. Sponsored-by: Main Library Alliance <https://www.mainlib.org/> Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.