https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143130|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 143357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143357&action=edit Bug 26635: AV expansion should ackowledge $params->{public} This patch simplifies the original implementation so it is more readable, removing extra loops and methods and just dealing with the coded values inline on the existing loops. It also adds non-public attributes removal from the original list, to address the changes introduced by bug 28948. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t \ t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.