[Koha-bugs] [Bug 38357] When adding new holidays Koha sometimes copies same holidays to other librarys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38357 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #13)

Is there a reason not to get rid of all the `our` variable definitions? I'm not sure we know exactly why it is being used.

We only know those variables persist in memory in Plack mode (and other persistent runtime environments).

It has a global scope, and is available from the subroutines. When switching to plack we (lazily) switched some "my" to "our" to just make things worked. It can be fixed, but it's not simply a s/^our/my/g substitution. But yes, it must be done. -- You are receiving this mail because: You are watching all bug changes.