https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39860 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
2. Why would we need to run this through the XSLTs?
Wouldn't it be more efficient add it to the return data of C4::XSLT::XSLTParse4Display()?
(That is, right now we return the return value of $engine->transform(), but we could store that, append to it, and then return that concatenated value. You might have a good reason for not doing that, but I don't see what it is at a glance on my own.)
You're right, no need to do that. I wrote a follow up to append the content you like suggest, after the XSLT transformation.
3. Technically, we don't use XHTML anymore - we use HTML5 which isn't fully XML-compatible, so in theory someone could enter valid HTML which might cause XSLT errors. I'd be curious how it handles HTML5's "<br>" instead of XHTML's "<br/>" for instance. I wonder if it would croak on there not being a closing tag.
This shouldn't be a problem now with the follow up patch not running through the XSLT transformation. -- You are receiving this mail because: You are watching all bug changes.