https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- my @valid_params = Koha::Patrons->_resultset->result_source->columns; Normally, we should not touch the private underscored subs like _resultset somewhere else? We also have _columns in Koha/Object. Should that be made public? In this specific case I even wonder if you should do this validation here in REST or just pass the params to Objects (Patrons) and validate there if needed. Would it be unexpected to return nothing if you search for an unexisting column? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.