https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Generally, this patch appears to work as expected so I'll sign it off. However, I have some feedback: 1/ I'd like to see the whole 'Desks' functionality behind a system preference so libraries not interested in using the feature don't see it. 2/ If there are not desks defined for the logged-in library then a trailing `|` is left in the header menu 3/ Should you not be able to set a Desk from the Login screen? 4/ Jury is out regarding adding the Desk into the header bar menu title.. I like that it's immediately obvious, but for narrow screens, this could cause issues? Copying in a few more people to get opinions. -- You are receiving this mail because: You are watching all bug changes.