https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #62 from Jonathan Druart <jonathan.druart@gmail.com> ---
1. There are no cypress tests
Yes, there are. See t/cypress/integration/SIP2.
No idea how I missed that!
4. If I upgrade I do have stuffs in the DB (picked from /etc/koha/sites/kohadev/SIPconfig.xml) but for new installs the table are not populated. Maybe we need to patch miscdev(?)
Out of scope here? AFAIK the 'dummy' existing config in SIPconfig.xml served only as documentation for all the possible configuration values for accounts + institutions + syspref overrides (which is what is migrated here). Server params and listeners are still read from the SIPconfig.xml file (as per DCook's original QA requirements).
It's a regression for ktd: we are expecting to have a working configuration. See https://gitlab.com/koha-community/koha-misc4dev/-/issues/35 and the related merge request "Issue #35 - Make SIP work out of the box"
7 Don't we want a config flag to turn off the ability to edit from the UI?
I don't think so? The ability to access and work with the module is already governed by the new 'sip2' permission.
Yes, but prior to this change only sysops were able to edit it. I would like Kyle and Tomas opinion on this one. Thanks for the other fixes! -- You are receiving this mail because: You are watching all bug changes.